Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RetryMiddleware default exponential delay #2132

Merged
merged 4 commits into from Dec 7, 2019
Merged

Fix RetryMiddleware default exponential delay #2132

merged 4 commits into from Dec 7, 2019

Commits on Dec 7, 2019

  1. Fix RetryMiddleware::exponentialDelay by making it return milliseconds 

    RetryMiddleware::exponentialDelay was being used as-is to set the delay option in the retry middleware. However, the option requires milliseconds and this method was returning seconds.
    @dluces @Nyholm
    dluces authored and Nyholm committed Dec 7, 2019
    Copy the full SHA
    c2b0f35 View commit details
    Browse the repository at this point in the history

  2. Fix RetryMiddleware::exponentialDelay by making it return milliseconds 

    RetryMiddleware::exponentialDelay was being used as-is to set the delay option in the retry middleware. However, the option requires milliseconds and this method was returning seconds.
    @dluces @Nyholm
    dluces authored and Nyholm committed Dec 7, 2019
    Copy the full SHA
    de9c8bd View commit details
    Browse the repository at this point in the history

  3. Fix exponentialDelay int casting

    @dluces @Nyholm
    dluces authored and Nyholm committed Dec 7, 2019
    Copy the full SHA
    cbf6130 View commit details
    Browse the repository at this point in the history

  4. Added comment

    @Nyholm
    Nyholm committed Dec 7, 2019
    Copy the full SHA
    04851a2 View commit details
    Browse the repository at this point in the history