Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Fixed deprecation warning in node test server" #2638

Merged
merged 2 commits into from May 17, 2020
Merged

Fix "Fixed deprecation warning in node test server" #2638

merged 2 commits into from May 17, 2020

Conversation

guilliamxavier
Copy link
Contributor

@guilliamxavier guilliamxavier mentioned this pull request May 13, 2020
Merged
@gmponos
Copy link
Member

gmponos commented May 14, 2020

Seems valid..
https://www.w3schools.com/nodejs/met_buffer_from.asp

@gmponos gmponos added this to the 6.5.x milestone May 14, 2020
@gmponos
Copy link
Member

gmponos commented May 16, 2020

can you add the error that is reported by PHPStan into baseline in order to make the build pass?

@guilliamxavier
Copy link
Contributor Author

@gmponos: done

@gmponos gmponos merged commit 351a213 into guzzle:6.5 May 17, 2020
@gmponos
Copy link
Member

gmponos commented May 17, 2020

thank you.

@guilliamxavier guilliamxavier deleted the patch-4 branch May 17, 2020 09:45
This was referenced May 17, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmponos gmponos gmponos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guilliamxavier @gmponos