Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Fixed deprecation warning in node test server" #2638

Merged
merged 2 commits into from May 17, 2020
Merged

Fix "Fixed deprecation warning in node test server" #2638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd583dc
Fix "Fixed deprecation warning in node test server
guilliamxavier May 13, 2020
40ab3d9
Ignore PHPStan error after review
guilliamxavier May 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions phpstan-baseline.neon
View file
Open in desktop
Expand Up @@ -495,6 +495,11 @@ parameters:
count: 1
path: src/Handler/CurlFactory.php

-
message: "#^Parameter \\#1 \\$filename of function is_dir expects string, string\\|false given\\.$#"
count: 1
path: src/Handler/CurlFactory.php

-
message: "#^Method GuzzleHttp\\\\Handler\\\\CurlFactory\\:\\:retryFailedRewind\\(\\) has no return typehint specified\\.$#"
count: 1
Expand Down
2 changes: 1 addition & 1 deletion tests/server.js
View file
Open in desktop
Expand Up @@ -178,7 +178,7 @@ var GuzzleServer = function(port, log) {
that.responses = JSON.parse(request.body);
for (var i = 0; i < that.responses.length; i++) {
if (that.responses[i].body) {
that.responses[i].body = new Buffer.from(that.responses[i].body, 'base64');
that.responses[i].body = Buffer.from(that.responses[i].body, 'base64');
}
}
if (that.log) {
Expand Down