Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency web-vitals to v3.0.0 #309

Merged
merged 18 commits into from Feb 2, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 12, 2022

Mend Renovate

Note includes minor config change to work with this breaking change: https://togithub.com/GoogleChrome/web-vitals/pull/225

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
web-vitals 2.0.0 -> 3.1.1 age adoption passing confidence
web-vitals ^2.0.0 -> ^2.0.0 || ^3.0.0 age adoption passing confidence

Release Notes

GoogleChrome/web-vitals

v3.1.1

Compare Source

  • Defer CLS logic until after onFCP() callback (#​297)

v3.1.0

Compare Source

  • Add support for 'restore' as a navigationType (#​284)
  • Report initial CLS value when reportAllChanges is true (#​283)
  • Defer all observers until after activation (#​282)
  • Ignore TTFB for loads where responseStart is zero (#​281)
  • Defer execution of observer callbacks (#​278)

v3.0.4

Compare Source

  • Clamp LCP and FCP to 0 for prerendered pages (#​270)

v3.0.3

Compare Source

  • Ensure attribution object is always present in attribution build (#​265)

v3.0.2

Compare Source

  • Set an explicit unpkg dist file (#​261)

v3.0.1

Compare Source

  • Use the cjs extension for all UMD builds (#​257)

v3.0.0

Compare Source

  • [BREAKING] Add a config object param to all metric functions (#​225)
  • [BREAKING] Report TTFB after a bfcache restore (#​220)
  • [BREAKING] Only include last LCP entry in metric entries (#​218)
  • Update the metric ID prefix for v3 (#​251)
  • Move the Navigation Timing API polyfill to the base+polyfill build (#​248)
  • Add a metric rating property (#​246)
  • Add deprecation notices for base+polyfill builds (#​242)
  • Add a new attribution build for debugging issues in the field (#​237, #​244)
  • Add support for prerendered pages (#​233)
  • Rename the ReportHandler type to ReportCallback, with alias for back-compat (#​225, #​227)
  • Add support for the new INP metric (#​221, #​232)
  • Rename getXXX() functions to onXXX() (#​222)
  • Add a navigationType property to the Metric object (#​219)

v2.1.4

Compare Source

  • Prevent TTFB from reporting after bfcache restore (#​201)

v2.1.3

Compare Source

  • Only call report if LCP occurs before first hidden (#​197)

v2.1.2

Compare Source

  • Ensure reported TTFB values are less than the current page time (#​187)

v2.1.1

Compare Source

  • Add feature detects to support Opera mini in extreme data saver mode (#​186)

v2.1.0

Compare Source

  • Add batch reporting support and guidance (#​166)

v2.0.1

Compare Source

  • Detect getEntriesByName support before calling (#​158)

Configuration

📅 Schedule: Branch creation - "before 3am on Monday" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner December 12, 2022 01:52
@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

🦋 Changeset detected

Latest commit: 1b62c14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/core-web-vitals Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 12, 2022
@renovate renovate bot force-pushed the renovate/web-vitals-3.x branch 10 times, most recently from 88b7a0b to 75da062 Compare December 15, 2022 14:40
@joecowton1 joecowton1 requested review from a team as code owners February 2, 2023 09:01
@renovate
Copy link
Contributor Author

renovate bot commented Feb 2, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

sndrs
sndrs previously approved these changes Feb 2, 2023
mxdvl
mxdvl previously requested changes Feb 2, 2023
Copy link
Member

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice the breaking changes from the peer dependency should be mentioned in this major release:

  • Add a config object param to all metric functions (#​225)
  • Report TTFB after a bfcache restore (#​220)
  • Only include last LCP entry in metric entries (#​218)

(sorry for the red tick, you only get one chance to draft major release notes)

libs/@guardian/core-web-vitals/package.json Show resolved Hide resolved
@joecowton1
Copy link
Contributor

In practice the breaking changes from the peer dependency should be mentioned in this major release:

  • Add a config object param to all metric functions (#​225)
  • Report TTFB after a bfcache restore (#​220)
  • Only include last LCP entry in metric entries (#​218)

(sorry for the red tick, you only get one chance to draft major release notes)

These are covered in the Renovate notes, is that not sufficient?

@sndrs
Copy link
Member

sndrs commented Feb 2, 2023

In practice the breaking changes from the peer dependency should be mentioned in this major release

is it really the job of a lib to describe the breaking changes of internal dependencies?

@joecowton1 joecowton1 changed the title Update dependency web-vitals to v3 Update dependency web-vitals to v3.0.0 Feb 2, 2023
@mxdvl mxdvl dismissed their stale review February 2, 2023 11:03

Convinced otherwise

@mxdvl
Copy link
Member

mxdvl commented Feb 2, 2023

In practice the breaking changes from the peer dependency should be mentioned in this major release

is it really the job of a lib to describe the breaking changes of internal dependencies?

It should not be, but when you know the consumers don’t have strictly enforced peer dependencies, it might be the nice thing to do?

@joecowton1
Copy link
Contributor

In practice the breaking changes from the peer dependency should be mentioned in this major release

is it really the job of a lib to describe the breaking changes of internal dependencies?

It should not be, but when you know the consumers don’t have strictly enforced peer dependencies, it might be the nice thing to do?

added to changeset :)

@joecowton1 joecowton1 merged commit ed13a6c into main Feb 2, 2023
@joecowton1 joecowton1 deleted the renovate/web-vitals-3.x branch February 2, 2023 15:11
@mxdvl mxdvl mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 npm Affects a @guardian package on NPM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants