Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade core-vitals to v3 #329

Closed
mxdvl opened this issue Dec 20, 2022 · 2 comments
Closed

Upgrade core-vitals to v3 #329

mxdvl opened this issue Dec 20, 2022 · 2 comments
Assignees
@mxdvl
Labels
enhancement New feature or request 📦 npm Affects a @guardian package on NPM

Comments

@mxdvl
Copy link
Member

mxdvl commented Dec 20, 2022

Context
Google’s web-vitals library has recently receive a major update (v3), which brings many breaking changes and new features.

Proposal
We should consider upgrading, in order to gain reporting on the new INP (Interaction to Next Paint), and possibly the metric rating property directly–'good', 'needs-improvement' or 'poor'.
@mxdvl mxdvl added enhancement New feature or request 📦 npm Affects a @guardian package on NPM labels Dec 20, 2022
@mxdvl mxdvl self-assigned this Dec 20, 2022
@mxdvl
Copy link
Member Author

mxdvl commented Dec 20, 2022

Hmm… I can see that this has gone into @guardian/client-side-infra’s Github Projects, happy to move over to dotcom the dotcom-rendering repo if it helps!

@mxdvl
Copy link
Member Author

mxdvl commented Mar 26, 2024

Fixed by #309

@mxdvl mxdvl closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxdvl mxdvl

Labels
enhancement New feature or request 📦 npm Affects a @guardian package on NPM
Projects
No open projects
WebX team (do not use)
Status: Todo (next priority)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mxdvl