Use http.DefaultTransport with custom TLS config #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTPDoWithOptionsE function has been updated to ensure we use http.DefaultTransport even when custom TLS config has been provided which ensures that HTTP/2 support is enabled in the HTTP client.
cbascom
requested review from
marinalimeira,
infraredgirl,
robmorgan and
ina-stoyanova
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTPDoWithOptionsE function has been updated to ensure we use
http.DefaultTransport even when custom TLS config has been provided
which ensures that HTTP/2 support is enabled in the HTTP client.
Description
Fixes #1139.
The function http_helper.HTTPDoWithOptionsE was attempting to use HTTP 1.x with TLSConfig, thus hitting the issue "net/http: HTTP/1.x transport connection broken: malformed HTTP response" .
This PR moves the mechanism that was added in #560 in method http_helper.HttpGetWithOptionsE into a new function that can be used in both places to build the HTTP client transport from http.DefaultTransport and then apply the custom TLS configuration.
I was not able to reproduce the actual error using the httptest.Server unfortunately, but new tests have been added to verify that custom TLS config can be used to successfully connect to a test server with TLS enabled. The test results for the http-helper module are here: https://gist.github.com/cbascom/f868e34f11ae7406efb927fbd9c3e1ab.