support HTTP/2 with TLS config in http_helper HTTPDo method #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngyl88
requested review from
ina-stoyanova,
infraredgirl,
marinalimeira and
robmorgan
as code owners
|
Hi @marinalimeira @yorinasub17 @brikis98 , could anyone help to review this change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
http_helper.HTTPDoEwas attempting to use HTTP 1.x with TLSConfig, thus hitting the issue "net/http: HTTP/1.x transport connection broken: malformed HTTP response" .http_helper.HttpGetE, PR#560 , to use DefaultTransport withForceAttemptHTTP2: true, when custom Dealer and TLS Config is injected.