Fix msbuild failing when '@' is present in path #31133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was ambiguity in references to Source metadata on some Items. These are now qualified to remove the ambiguity.
jtattermusch
added
the
release notes: yes
jtattermusch
approved these changes
Oct 24, 2022
|
@tonydnewell Some required tests haven't run since the branch of this PR is slightly old - can you please rebase on top of master to re-run the tests. I will then merge. |
copybara-service
bot
added
the
imported
jtattermusch
added a commit
that referenced
this pull request
Oct 26, 2022
This reverts commit 1a5ad72.
jtattermusch
added a commit
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #30746 - "C# Protobuf msbuild task fails with glob pattern if "@" is present in the path"
There was ambiguity in references to
%(Source)metadata on some items. These are now qualified to remove the ambiguity. This is what was causing the problems when there was a '@' in the path to the proto files.Also fix the printing of the warning for 'no known outputs' - it was using the wrong item list so no file names where output.
Testing on Windows and Linux on various Grpc projects.