Revert "Fix msbuild failing when '@' is present in path" #31464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1a5ad72.
jtattermusch
added
the
release notes: yes
apolcyn
approved these changes
Oct 26, 2022
copybara-service
bot
added
the
imported
stanley-cheung
deleted the
revert-31133-bugfix/30746-grpc.tools-at-in-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #31133
I just found that the changes in the PR very likely break the (non-yet-added) C# distribtests from
#31436.
On the PR I got this failure
https://source.cloud.google.com/results/invocations/08298adc-8586-494c-8488-836f3b505cef/targets;collapsed=/github%2Fgrpc%2Fdistribtests/tests;passed=true and the problem goes away when I reverted the changes from #31133 locally.
The best way forward is to revert #31133, then merge the PR that adds the distribtest and only reintroduce #31133 when the distribtests are happy.