Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the Google.Protobuf version to the latest. #21544

Closed
wants to merge 1 commit into from
Closed

Updates the Google.Protobuf version to the latest. #21544

wants to merge 1 commit into from

Conversation

Dig-Doug
Copy link

This PR (and maybe others) changed the API of the generated code so the packaged Google.Protobuf version is not compatible with code files generated with the latest code generation plugin.

Example error:

error CS1729: 'GeneratedClrTypeInfo' does not contain a constructor that takes 7 arguments

@yashykt

[This PR](protocolbuffers/protobuf#5350) (and maybe others) changed the API of the generated code so the packaged Google.Protobuf version is not compatible with code files generated with the latest code generation plugin.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 21, 2019

CLA Check
The committers are authorized under a signed CLA.

@jtattermusch jtattermusch self-requested a review December 23, 2019 15:22
@jtattermusch jtattermusch self-assigned this Dec 23, 2019
@jtattermusch
Copy link
Contributor

I'm afraid many other places need to be updated for this to work.

@Dig-Doug
Copy link
Author

Dig-Doug commented Jan 1, 2020

Thanks for taking a look. I've filed #21571 to track this.

@Dig-Doug Dig-Doug closed this Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants