Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google.Protobuf version in Unity package #21571

Closed
Dig-Doug opened this issue Jan 1, 2020 · 4 comments
Closed

Update Google.Protobuf version in Unity package #21571

Dig-Doug opened this issue Jan 1, 2020 · 4 comments

Comments

@Dig-Doug
Copy link

Dig-Doug commented Jan 1, 2020

Context

I am using the grpc unity package in my project. I generate my C# protos outside of unity with bazel using the latest protoc/grpc versions and import them into my project. Recently, I ran into an issue where the generated code was not compatible with the latest grpc-unity package. Here's an example of the error I saw:

error CS1729: 'GeneratedClrTypeInfo' does not contain a constructor that takes 7 arguments

After some digging, I found that this PR (and maybe others) changed the API of the generated code so the packaged Google.Protobuf version in the unity package is not compatible with code files generated with the latest code generation plugins.

Is it possible to update the unity package to use the latest versions?

Thanks for your help!

@jtattermusch

@jtattermusch
Copy link
Contributor

I am planning to upgrade protobuf in our repository soon, but for your use case, the only thing you need to do is to make sure that you're using compatible versions of protoc, grpc_csharp_plugin and the Google.Protobuf runtime. This should be pretty easy to achieve.

@jtattermusch
Copy link
Contributor

#21590

@stale
Copy link

stale bot commented May 6, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@jtattermusch
Copy link
Contributor

#21590 has been merged for a while, which should have fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants