core: Use SyncContext for InProcessTransport listener callbacks to avoid deadlocks #9319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Jun 28, 2022
|
The "Fixes bug #3084" is normally just included in the commit/PR description, not the title. And we use "Fixes #3084" syntax so github auto-links the PR to the issue. See #9300 for an example. |
larry-safran
changed the title
larry-safran
changed the title
ejona86
reviewed
Jun 29, 2022
…void deadlocks Fixes grpc#3084 Also support unary calls returning null values
ejona86
approved these changes
Jun 30, 2022
ejona86
added
the
TODO:backport
|
Hi @larry-safran @ejona86 do we still want to back port this change? |
larry-safran
removed
the
TODO:backport
|
After discussing with Eric, we decided that it would be better at this
point not to backport it since nobody has been running with it.
Thanks for the reminder,
Larry
…On Mon, Jul 11, 2022 at 9:38 AM yifeizhuang ***@***.***> wrote:
Hi @larry-safran <https://github.com/larry-safran> @ejona86
<https://github.com/ejona86> do we still want to back port this change?
—
Reply to this email directly, view it on GitHub
<#9319 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZQMCXSGNAQSLJQ4FKQFS43VTREW3ANCNFSM52AOJP2Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Sep 20, 2022
These tests verify corner cases in the bidirectional BES protocol and had been relying on the in-process gRPC transport with direct execution to correctly use concurrency primitives. Since the inprocess gRPC transport was changed in grpc/grpc-java#9319 these tests are no longer correct and need to be carefully updated to match the new inprocess gRPC threading model. Updating the tests will take long enough that temporarily ignoring the tests will meaningfully reduce CI flakes. PiperOrigin-RevId: 475617300 Change-Id: Ibf27e10b433030ede29fe0587315fbad1a76dbe0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deadlocks caused by client and server listeners being called in a synchronized block
Also support unary calls returning null values
Fixes #3084