Skip to content

Commit

Permalink
Mark two flaky BES tests with @ignore until a fix is written.
Browse files Browse the repository at this point in the history
These tests verify corner cases in the bidirectional BES protocol and had
been relying on the in-process gRPC transport with direct execution to
correctly use concurrency primitives. Since the inprocess gRPC transport
was changed in grpc/grpc-java#9319 these tests
are no longer correct and need to be carefully updated to match the new
inprocess gRPC threading model. Updating the tests will take long enough
that temporarily ignoring the tests will meaningfully reduce CI flakes.

PiperOrigin-RevId: 475617300
Change-Id: Ibf27e10b433030ede29fe0587315fbad1a76dbe0
  • Loading branch information
michaeledgar authored and Copybara-Service committed Sep 20, 2022
1 parent 7f32687 commit 3599b25
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
import javax.annotation.concurrent.GuardedBy;
import org.junit.After;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
Expand Down Expand Up @@ -442,6 +443,9 @@ public void testBeforeSecondCommand_fullyAsync_slowFullCloseIgnored() throws Exc
events.assertNoWarningsOrErrors();
}

// TODO(b/246912214): Deflake this by fixing the threading model to match the upstream gRPC
// changes in https://github.com/grpc/grpc-java/pull/9319 that affect InProcessTransport.
@Ignore("b/246912214")
@Test
public void testBeforeSecondCommand_fullyAsync_slowHalfCloseWarning() throws Exception {
buildEventService.setDelayBeforeHalfClosingStream(Duration.ofSeconds(10));
Expand All @@ -464,6 +468,9 @@ public void testBeforeSecondCommand_fullyAsync_besTimeout_slowFullCloseIgnored()
events.assertNoWarningsOrErrors();
}

// TODO(b/246912214): Deflake this by fixing the threading model to match the upstream gRPC
// changes in https://github.com/grpc/grpc-java/pull/9319 that affect InProcessTransport.
@Ignore("b/246912214")
@Test
public void testBeforeSecondCommand_fullyAsync_besTimeout_slowHalfCloseWarning()
throws Exception {
Expand Down

0 comments on commit 3599b25

Please sign in to comment.