rls: overhaul RouteLookupConfig validation #8645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
commented
Nov 18, 2021
dapengzhang0
changed the title
dapengzhang0
force-pushed
the
fix-rls-data
branch
from
d0931c7
to
3b1f2a3
Compare
sergiitk
requested changes
Nov 24, 2021
Comment on lines
+167
to
+168
| this.maxAgeInNanos = maxAgeInNanos; | ||
| this.staleAgeInNanos = staleAgeInNanos; |
There was a problem hiding this comment.
Potential error: Unboxing LongmaxAgeInNanos and staleAgeInNanos into long this.maxAgeInNanos and this.staleAgeInNanos may produce 'NullPointerException'.
There was a problem hiding this comment.
This is an oversight. Fixed to use primitive long type.
dapengzhang0
commented
Nov 30, 2021
Comment on lines
+167
to
+168
| this.maxAgeInNanos = maxAgeInNanos; | ||
| this.staleAgeInNanos = staleAgeInNanos; |
There was a problem hiding this comment.
This is an oversight. Fixed to use primitive long type.
sergiitk
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Looks good. Minor comments + you missed one on the deleted code: #8645 (comment)
sergiitk
added a commit
to sergiitk/grpc-java
that referenced
this pull request
Dec 1, 2021
This PR fixes a few cosmetic violations of the ErrorProne patterns introduced in PR grpc#8645: ParameterName, and TimeUnitMismatch.
sergiitk
added a commit
that referenced
this pull request
Dec 1, 2021
This PR fixes a few cosmetic violations of the ErrorProne patterns introduced in PR #8645: ParameterName, and TimeUnitMismatch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RlsProtoData.RouteLookupConfigclass is out-of-date.Durationtype.Now overhaul all the fields in
RlsProtoData.RouteLookupConfigclass based on the spec http://go/grpc-rls-lb-policy-design#heading=h.y3h669gfpown.Also move the validation logic in json parsing rather than in the constructor of
RouteLookupConfig.