Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls: Fix RouteLookupConfig test arguments #8734

Merged
merged 1 commit into from Dec 1, 2021

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Dec 1, 2021

This PR fixes a few cosmetic violations of the ErrorProne patterns introduced in PR #8645: ParameterName, and TimeUnitMismatch.

This PR fixes a few cosmetic violations of the ErrorProne patterns
introduced in PR grpc#8645: ParameterName, and TimeUnitMismatch.
@sergiitk sergiitk enabled auto-merge (rebase) December 1, 2021 23:19
@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 1, 2021
Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix~

@sergiitk sergiitk merged commit 7aaa418 into grpc:master Dec 1, 2021
@sergiitk sergiitk deleted the fix-RouteLookupConfig-test-args branch December 2, 2021 00:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants