rls: Fix RouteLookupConfig test arguments

This PR fixes a few cosmetic violations of the ErrorProne patterns introduced in PR grpc#8645: ParameterName, and TimeUnitMismatch.
sergiitk · Dec 1, 2021 · cae584a · cae584a
1 parent 27b03c6
commit cae584a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/rls/src/test/java/io/grpc/rls/RlsProtoConvertersTest.java b/rls/src/test/java/io/grpc/rls/RlsProtoConvertersTest.java
@@ -199,7 +199,7 @@ public void convert_jsonRlsConfig() throws IOException {
                     ExtraKeys.create("host-key", "service-key", "method-key"),
                     ImmutableMap.of("constKey1", "value1"))),
             /* lookupService= */ "service1",
-            /* lookupServiceTimeoutInMillis= */ TimeUnit.SECONDS.toNanos(2),
+            /* lookupServiceTimeoutInNanos= */ TimeUnit.SECONDS.toNanos(2),
             /* maxAgeInNanos= */ TimeUnit.SECONDS.toNanos(300),
             /* staleAgeInNanos= */ TimeUnit.SECONDS.toNanos(240),
             /* cacheSizeBytes= */ 1000,
@@ -351,7 +351,7 @@ public void convert_jsonRlsConfig_defaultValues() throws IOException {
                     ExtraKeys.DEFAULT,
                     ImmutableMap.<String, String>of())),
             /* lookupService= */ "service1",
-            /* lookupServiceTimeoutInMillis= */ TimeUnit.SECONDS.toNanos(10),
+            /* lookupServiceTimeoutInNanos= */ TimeUnit.SECONDS.toNanos(10),
             /* maxAgeInNanos= */ TimeUnit.MINUTES.toNanos(5),
             /* staleAgeInNanos= */ TimeUnit.MINUTES.toNanos(5),
             /* cacheSizeBytes= */ 5 * 1024 * 1024,
@@ -409,7 +409,7 @@ public void convert_jsonRlsConfig_staleAgeCappedByMaxAge() throws IOException {
                     ExtraKeys.DEFAULT,
                     ImmutableMap.<String, String>of())),
             /* lookupService= */ "service1",
-            /* lookupServiceTimeoutInMillis= */ TimeUnit.SECONDS.toNanos(2),
+            /* lookupServiceTimeoutInNanos= */ TimeUnit.SECONDS.toNanos(2),
             /* maxAgeInNanos= */ TimeUnit.SECONDS.toNanos(300),
             /* staleAgeInNanos= */ TimeUnit.SECONDS.toNanos(300),
             /* cacheSizeBytes= */ 1000,

diff --git a/rls/src/test/java/io/grpc/rls/RlsRequestFactoryTest.java b/rls/src/test/java/io/grpc/rls/RlsRequestFactoryTest.java
@@ -65,9 +65,9 @@ public class RlsRequestFactoryTest {
                   ExtraKeys.create(null, null, null),
                   ImmutableMap.of("const-key-4", "const-value-4"))),
           /* lookupService= */ "bigtable-rls.googleapis.com",
-          /* lookupServiceTimeoutInMillis= */ TimeUnit.SECONDS.toMillis(2),
-          /* maxAgeInMillis= */ TimeUnit.SECONDS.toMillis(300),
-          /* staleAgeInMillis= */ TimeUnit.SECONDS.toMillis(240),
+          /* lookupServiceTimeoutInNanos= */ TimeUnit.SECONDS.toNanos(2),
+          /* maxAgeInNanos= */ TimeUnit.SECONDS.toNanos(300),
+          /* staleAgeInNanos= */ TimeUnit.SECONDS.toNanos(240),
           /* cacheSizeBytes= */ 1000,
           /* defaultTarget= */ "us_east_1.cloudbigtable.googleapis.com");