pickfirst: cleanup tests #5263
Merged
pickfirst: cleanup tests #5263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
Mar 22, 2022
| @@ -79,6 +80,13 @@ func startServers(t *testing.T, numServers int, maxStreams uint32) ([]*server, f | |||
| } | |||
| } | |||
|
|
|||
| func errorDesc(err error) string { | |||
There was a problem hiding this comment.
Currently called from balancer_switching_test.go, server_test.go and pickfirst_test.go. All references to this from the last file are removed in this PR.
menghanl
approved these changes
Mar 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the changes to be made for #5260.
Summary of changes:
pickfirst_test.goand puts them intest/pickfirst_test.go. This ensures that we use the public API.pick_firstis working as expected.Note:
TestNewAddressWhileBlockingPickfirsthas been removed and will be added when the changes forpickfirstmust move toTransientFailureif it receives empty addresses #5260 are made.TestCloseWithPendingRPCPickfirsthas been removed. The same was done whenround_robintests were cleaned up as part of test: cleanup roundrobin tests to use stubserver #5236. This test has nothing to do with what LB policy is configured on the channel. I plan to add this test as aClientConntest in a follow-up PR.RELEASE NOTES: none