test: add a test for clientConn close with pending RPC #5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
suggested changes
Mar 22, 2022
test/clientconn_test.go
Outdated
|
|
||
| r := manual.NewBuilderWithScheme("whatever") | ||
|
|
||
| // Spin up a backend exposing the TestService. |
There was a problem hiding this comment.
Do we need the backend at all?
There was a problem hiding this comment.
You are right. Got rid of it. Thanks.
menghanl
approved these changes
Mar 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, we had two tests for this same scenario:
round_robintests (removed in test: cleanup roundrobin tests to use stubserver #5236)pick_firsttests (removed in pickfirst: cleanup tests #5263)None of the above two tests were in the appropriate location because the functionality being tested here does not depend on what LB policy is configured on the channel.
Hence this test is being moved out into a standalone
ClientConntest.RELEASE NOTES: none