Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflection: use protobuf/reflect instead of go reflection, fix dynamic messages #5180

Merged
merged 7 commits into from Feb 15, 2022

Commits on Jan 30, 2022

  1. reflection: use protobuf/reflect instead of go reflection, fix dynamicpb

    The reflection service panics when it encounters a dynamically-created message.
    
    The panic happens here:
    
      m, ok := reflect.Zero(reflect.PtrTo(st)).Interface().(protoMessage)
    
    This is because `st` is a `dynamicpb.Message` which can't be created using go reflection.
    
    Rather than add special handling for dynamic messages, migrating the reflection service to use protobuf/reflection instead of go reflection both solves the problem and cleans up a lot of code.
    codebutler committed Jan 30, 2022
    Copy the full SHA
    f11ad71 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Copy the full SHA
    0f20ccf View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    93b08e0 View commit details
    Browse the repository at this point in the history
  3. fix tests

    codebutler committed Feb 9, 2022
    Copy the full SHA
    9086c5b View commit details
    Browse the repository at this point in the history
  4. fix go package

    codebutler committed Feb 9, 2022
    Copy the full SHA
    0295f58 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Copy the full SHA
    effa99d View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    31aa2ec View commit details
    Browse the repository at this point in the history