reflection: use protobuf/reflect instead of go reflection, fix dynamic messages #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reflection service panics when it encounters a dynamically-created message. The panic happens here: m, ok := reflect.Zero(reflect.PtrTo(st)).Interface().(protoMessage) This is because `st` is a `dynamicpb.Message` which can't be created using go reflection. Rather than add special handling for dynamic messages, migrating the reflection service to use protobuf/reflection instead of go reflection both solves the problem and cleans up a lot of code.
|
|
menghanl
suggested changes
Jan 31, 2022
reflection/serverreflection_test.go
Outdated
| @@ -78,65 +84,43 @@ func loadFileDesc(filename string) (*dpb.FileDescriptorProto, []byte) { | |||
| return fd, b | |||
| } | |||
|
|
|||
| func loadFileDescDynamic(filename string) (*dpb.FileDescriptorProto, []byte) { | |||
| p := &protoparse.Parser{} | |||
| fds, err := p.ParseFiles(filename) | |||
There was a problem hiding this comment.
This will need to call testdata.Path(filename) to avoid potential problems caused by file path.
|
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
|
@codebutler : Do you have any update here? Thanks. |
|
Thanks for the review. I'll make those changes shortly, sorry for the delay. |
menghanl
reviewed
Feb 9, 2022
menghanl
reviewed
Feb 9, 2022
menghanl
suggested changes
Feb 10, 2022
menghanl
approved these changes
Feb 10, 2022
dfawley
approved these changes
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reflection service panics when it encounters a dynamically-created message:
https://gist.github.com/codebutler/92539e14f46bc460a6cd695b801e946a
The panic happens here:
This is because
stis adynamicpb.Messagewhich can't be created using go reflection.Rather than add special handling for dynamic messages, migrating the reflection service to use protobuf/reflection instead of go reflection both solves the problem and cleans up a lot of code.
RELEASE NOTES: