Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/clusterimpl: fix SubConn wrapper returned by picker during race #4876

Merged
merged 1 commit into from
Oct 15, 2021
Merged

xds/clusterimpl: fix SubConn wrapper returned by picker during race #4876

merged 1 commit into from
Oct 15, 2021

Commits on Oct 15, 2021

  1. [clusterimpl_pick_sc_wrong_type] xds/clusterimpl: fix SubConn wrapper… 

    … returned by picker during race

The previous logic is that the picker updated with a non-Ready state
should always return error, so the clusterimpl picker doesn't try to
unwrap the SubConn.

The assumption is not true, in cases like ring_hash (where the picker is
mutable, and could start to return SubConns before the overall state is
updated to Ready during races).
    @menghanl
    menghanl committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    42d071f View commit details
    Browse the repository at this point in the history