Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Clarify that WaitForReady will block for CONNECTING channels #4477

Merged
merged 2 commits into from Jun 1, 2021
Merged

client: Clarify that WaitForReady will block for CONNECTING channels #4477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
319fb63
client: Clarify that WaitForReady will block for CONNECTING channels
evanj May 21, 2021
fb189ab
code review suggestion: Only mention TRANSIENT_FAILURE state
evanj May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion rpc_util.go
View file
Open in desktop
Expand Up @@ -258,7 +258,8 @@ func (o PeerCallOption) after(c *callInfo, attempt *csAttempt) {
}

// WaitForReady configures the action to take when an RPC is attempted on broken
// connections or unreachable servers. If waitForReady is false, the RPC will fail
// connections or unreachable servers. If waitForReady is false and the
// connection is in the TRANSIENT_FAILURE state, the RPC will fail
// immediately. Otherwise, the RPC client will block the call until a
// connection is available (or the call is canceled or times out) and will
// retry the call if it fails due to a transient error. gRPC will not retry if
Expand Down