Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Clarify that WaitForReady will block for CONNECTING channels #4477

Merged
merged 2 commits into from Jun 1, 2021
Merged

client: Clarify that WaitForReady will block for CONNECTING channels #4477

merged 2 commits into from Jun 1, 2021

Commits on May 21, 2021

  1. client: Clarify that WaitForReady will block for CONNECTING channels 

    The WaitForReady option documentation was not clear to me, until I
read the linked documentation [1]. Include the channel state names
that cause an RPC to fail immediately to attempt to clarify how this
works.

[1] https://github.com/grpc/grpc/blob/master/doc/wait-for-ready.md
    @evanj
    evanj committed May 21, 2021
    Copy the full SHA
    319fb63 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. code review suggestion: Only mention TRANSIENT_FAILURE state

    @evanj
    evanj committed May 27, 2021
    Copy the full SHA
    fb189ab View commit details
    Browse the repository at this point in the history