Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#267] update build pipeline #268

Closed
wants to merge 1 commit into from

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Sep 25, 2023

  • Define min and max memory for maven
  • move common maven options to variabble
  • Build matrix of JDK 11, 17 and Groovy 3-latest and 4-latest.

Other things to note:

  • Remove node12-based actions (checkout v2)
  • Use a specific distribution (temurin for now, most common))
  • remove default architecture 'x64'
  • Option to add Java 21 later
  • Option to add groovy 5 later
  • Check includes default versions as defined in pom by using empty string
  • Features github expressions instead of relying on bash strict mode (which doesn't work the way you think)

@bmarwell
Copy link
Contributor Author

Actually, I can also use a 2.x version this way. Will update the PR

@keeganwitt
Copy link
Member

I copy/pasted most of this over to #269

@keeganwitt
Copy link
Member

I think I've moved over everything from this PR. Thanks for this! It's much cleaner than what I was playing with.

I think we can close this now. Lemme know if there's anything I missed.

@keeganwitt keeganwitt closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants