Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#265] remove indy profiles #266

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Sep 25, 2023

Fixes #265

indy (Invoke Dynamic) dependency classifier is not used anymore in recent groovy versions.

pom.xml Outdated Show resolved Hide resolved
@@ -25,4 +25,4 @@ jobs:
# - name: integration test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had thought perhaps I might use a shorter test for PRs. But I'm thinking now I probably won't ever do that. Might make sense to just delete these unused steps (which still have references to the old profile).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3min is fine. Locally, just don't run the invoker stuff, and you are done.
Thinking of invoker: I wanted to raise another issue where I put everything into a profile instead (and making 'install' not needed for integration testing). install will clutter and spam your local .m2 folder, so it is common to avoid this whenever possible.
But that's for another issue. I can put all the details there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that line in this PR: #268

@keeganwitt keeganwitt merged commit ade990c into groovy:master Sep 25, 2023
2 checks passed
@bmarwell bmarwell deleted the #265_remove_indy_profiles branch September 26, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'indy' and 'nonindy' profiles
2 participants