fix(#1747): Replace deprecated props in mui based components #1748

Kalaiz · 2021-07-13T18:53:47Z

Material-ui will be migrating from v4 to v5 and has been deprecating stuffs as a part of that move. Deprecation warnings as stated in #1747 appears when MUI-Datatable is used. This PR fixes it by using the recommendations provided by material-ui, in regards to the deprecations.

Used TransitionProps instead of the deprecated onClose and onExited Props for material-ui based Popover.
Used onPageChange and onRowsPageChange Props instead of the deprecated onChangePage and onChangeRowsPerPage Props respectively, for material-ui based TablePagination.
Used ref instead of the deprecated buttonRef for material-ui based IconButton. Note: In addition to those mentioned in Warnings from deprecated\old props #1747, I faced the below warning as well:

Warning: Failed prop type: The prop buttonRef of ForwardRef(ButtonBase) is deprecated. Use ref instead..

If I am not wrong, I believe it is caused by the warnings added in material ui 4.12.0 release and there are indeed going to remove buttonRef as seen in one of the v5 pre-releases.

I tried running the npm test, however, I faced the same error as mentioned in here.

- Used TransitionProps instead of the deprecated onClose and onExited Props for material-ui based Popover. - Used onPageChange and onRowsPageChange Props instead of the deprecated onChangePage and onChangeRowsPerPage Props respectively, for material-ui based TablePagination. - Used ref instead of the deprecated buttonRef for material-ui based IconButton .

VitorMiguelPS · 2021-07-27T14:15:19Z

There is any estimate to implement this PR?

li-baptistegaspari · 2021-07-30T09:34:51Z

There is any estimate to implement this PR?

+1

kingeke · 2021-08-02T13:10:02Z

Please can this be merged, thank you...

joaomantovani · 2021-08-12T17:35:09Z

When it's going to be released?

joaomantovani · 2021-08-12T18:13:09Z

If anyone is facing this problem on production and needs to fix this immediately, I've created a fork from this repo and merged this PR on own master and created a manual release

Run this on your terminal:

yarn add https://github.com/penseapp/mui-datatables

or

npm i https://github.com/penseapp/mui-datatables

Warning

This will work but needs to be temporary, after merge of this PR, you should alter your package.json again!

ghost · 2021-08-18T21:00:59Z

I haven't seen any response from those with the power to push changes, I've had luck with @wdh2100 reviewing and pushing changes. Maybe we can summon him.

hs-analysis · 2021-08-23T13:27:21Z

If anyone is facing this problem on production and needs to fix this immediately, I've created a fork from this repo and merged this PR on own master and created a manual release

Run this on your terminal:
yarn add https://github.com/penseapp/mui-datatables
or
npm i https://github.com/penseapp/mui-datatables
Warning:
This will work but needs to be temporary, after merge os this PR, you should alter your package.json again!

I can't install the fork and get error messages beginning with "npm ERR! prepareGitDep
One interesting one is:
npm ERR! prepareGitDep npm ERR! A complete log of this run can be found in:

dan05011991 · 2021-08-24T07:37:46Z

I haven't seen any response from those with the power to push changes, I've had luck with @wdh2100 reviewing and pushing changes. Maybe we can summon him.

Hoping for this to get merged soon, saves us forking the repo temporarily

Messhias · 2021-08-26T18:17:02Z

@gregnb when you can merge this PR? There are others maintainers on this repo also to help you out?

emekaokoli · 2021-08-31T11:03:41Z

please is there a fix already? v3.7.8 still throws the same errors

dan05011991 · 2021-08-31T18:50:59Z

please is there a fix already? v3.7.8 still throws the same errors

Its waiting on a merge. 3.7.8 wouldn't contain the fix.

li-baptistegaspari · 2021-09-15T08:14:10Z

up ?

Messhias · 2021-09-15T09:33:59Z

@gregnb we're waiting for some feedback, can you please increase the maintainers on this repository?

kingeke · 2021-09-15T12:26:57Z

I do home covid didn't get you @gregnb :(

Messhias · 2021-09-16T06:46:27Z

I do home covid didn't get you @gregnb :(

Now you're saying that I got quite worried. It's been a while since his last activity in Github.

dan05011991 · 2021-09-28T19:02:39Z

Any movement on this?

emekaokoli · 2021-10-01T12:56:29Z

Please any update?

adriprmn · 2021-10-12T15:04:53Z

@gregnb you good?

mattshoaf · 2021-10-22T15:12:02Z

Based on the last several releases, it looks like @wdh2100 is maintaining this now. For MUI5 compatibility with need this pull request and #1772 merged in please.

wdh2100

@Kalaiz LGTM 👍

Forgive me for being late. 😢

Cirelion · 2021-10-25T10:24:04Z

I was just about to make a manual fork, you couldn't have had better timing! Thanks!

wdh2100 · 2021-10-25T10:36:37Z

@Cirelion

It will be released(3.8.0) soon with some bugs.

Cirelion · 2021-10-25T10:47:29Z

@wdh2100 Some bugs I can work with! Do you have a rough estimate for when it will be released?

wdh2100 · 2021-10-25T11:00:15Z

@Cirelion

Release 3.8.0

Darkmift · 2022-02-28T13:11:46Z

issue still ongoing...resorted to using:
mbrn/material-table#2937 (comment)

RohitAjith approved these changes Jul 22, 2021

View reviewed changes

GHMeyer0 approved these changes Jul 23, 2021

View reviewed changes

kingeke mentioned this pull request Aug 4, 2021

Depreciation Warnings #1757

Closed

This was referenced Aug 13, 2021

The prop onChangePage of ForwardRef(TablePagination) is deprecated #1759

Closed

Warnings from deprecated\old props #1747

Open

hs-analysis mentioned this pull request Aug 23, 2021

Warning: Failed Prop type #1765

Open

Messhias approved these changes Aug 26, 2021

View reviewed changes

IBonkI mentioned this pull request Sep 2, 2021

Uncaught TypeError: onPageChange is not a function #1735

Open

gnowland mentioned this pull request Oct 18, 2021

Upgrade to Material-UI 5 #1772

Merged

wdh2100 added the material ui 5.0 label Oct 25, 2021

wdh2100 mentioned this pull request Oct 25, 2021

fix: fixed all deprecation warnings #1796

Closed

wdh2100 approved these changes Oct 25, 2021

View reviewed changes

wdh2100 merged commit 99530f0 into gregnb:master Oct 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(#1747): Replace deprecated props in mui based components #1748

fix(#1747): Replace deprecated props in mui based components #1748

Kalaiz commented Jul 13, 2021

VitorMiguelPS commented Jul 27, 2021

li-baptistegaspari commented Jul 30, 2021

kingeke commented Aug 2, 2021

joaomantovani commented Aug 12, 2021

joaomantovani commented Aug 12, 2021 •

edited

ghost commented Aug 18, 2021

hs-analysis commented Aug 23, 2021 •

edited

dan05011991 commented Aug 24, 2021

Messhias commented Aug 26, 2021

emekaokoli commented Aug 31, 2021

dan05011991 commented Aug 31, 2021

li-baptistegaspari commented Sep 15, 2021

Messhias commented Sep 15, 2021

kingeke commented Sep 15, 2021

Messhias commented Sep 16, 2021

dan05011991 commented Sep 28, 2021

emekaokoli commented Oct 1, 2021

adriprmn commented Oct 12, 2021

mattshoaf commented Oct 22, 2021

wdh2100 left a comment •

edited

Cirelion commented Oct 25, 2021

wdh2100 commented Oct 25, 2021

Cirelion commented Oct 25, 2021

wdh2100 commented Oct 25, 2021

Darkmift commented Feb 28, 2022

fix(#1747): Replace deprecated props in mui based components #1748

fix(#1747): Replace deprecated props in mui based components #1748

Conversation

Kalaiz commented Jul 13, 2021

VitorMiguelPS commented Jul 27, 2021

li-baptistegaspari commented Jul 30, 2021

kingeke commented Aug 2, 2021

joaomantovani commented Aug 12, 2021

joaomantovani commented Aug 12, 2021 • edited

Warning

ghost commented Aug 18, 2021

hs-analysis commented Aug 23, 2021 • edited

dan05011991 commented Aug 24, 2021

Messhias commented Aug 26, 2021

emekaokoli commented Aug 31, 2021

dan05011991 commented Aug 31, 2021

li-baptistegaspari commented Sep 15, 2021

Messhias commented Sep 15, 2021

kingeke commented Sep 15, 2021

Messhias commented Sep 16, 2021

dan05011991 commented Sep 28, 2021

emekaokoli commented Oct 1, 2021

adriprmn commented Oct 12, 2021

mattshoaf commented Oct 22, 2021

wdh2100 left a comment • edited

Choose a reason for hiding this comment

Cirelion commented Oct 25, 2021

wdh2100 commented Oct 25, 2021

Cirelion commented Oct 25, 2021

wdh2100 commented Oct 25, 2021

Darkmift commented Feb 28, 2022

joaomantovani commented Aug 12, 2021 •

edited

hs-analysis commented Aug 23, 2021 •

edited

wdh2100 left a comment •

edited