Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings from deprecated\old props #1747

Open
ariel-upstream opened this issue Jul 13, 2021 · 6 comments
Open

Warnings from deprecated\old props #1747

ariel-upstream opened this issue Jul 13, 2021 · 6 comments

Comments

@ariel-upstream
Copy link

Hi,

After update to the last Material-UI version: 4.12.1,
I'm getting a lot of warnings from the table,

The warnings:

  1. Warning: Failed prop type: The prop onExited of ForwardRef(Popover) is deprecated. Use the TransitionProps prop instead.
  2. Warning: Failed prop type: The prop onChangePage of ForwardRef(TablePagination) is deprecated. Use the onPageChange prop instead.
  3. Warning: Failed prop type: The prop onChangeRowsPerPage of ForwardRef(TablePagination) is deprecated. Use the onRowsPerPageChange prop instead.
  4. Warning: Failed prop type: The prop onPageChange is marked as required in ForwardRef(TablePagination), but its value is undefined.

Thanks.

@ariel-upstream ariel-upstream changed the title Warnings from deprecated props Warnings from deprecated\old props Jul 13, 2021
Kalaiz added a commit to Kalaiz/mui-datatables that referenced this issue Jul 13, 2021
- Used TransitionProps instead of the deprecated onClose and onExited Props for material-ui based Popover.

- Used onPageChange and onRowsPageChange Props instead of the deprecated onChangePage and onChangeRowsPerPage Props respectively, for material-ui based TablePagination. 

- Used ref instead of the deprecated buttonRef for material-ui based IconButton .
@joaomantovani
Copy link

Facing the same issue

@jelling
Copy link

jelling commented Aug 9, 2021

Material-table had the same issue and here is how we people are working around it until the fix is released: mbrn/material-table#2937 (comment)

joaomantovani added a commit to penseapp/mui-datatables that referenced this issue Aug 12, 2021
…ed-props-material-ui-4.12.1

fix(gregnb#1747): Replace deprecated props in mui based components
@joaomantovani
Copy link

wdh2100 added a commit that referenced this issue Oct 25, 2021
…ps-material-ui-4.12.1

fix(#1747): Replace deprecated props in mui based components
@dan05011991
Copy link

Should now be resolved with latest version

@chickahoona
Copy link

I can confirm that 3.8.2 fixes the warnings / errors.

bmlkc pushed a commit to Telesero/mui-datatables that referenced this issue Feb 1, 2022
- Used TransitionProps instead of the deprecated onClose and onExited Props for material-ui based Popover.

- Used onPageChange and onRowsPageChange Props instead of the deprecated onChangePage and onChangeRowsPerPage Props respectively, for material-ui based TablePagination.

- Used ref instead of the deprecated buttonRef for material-ui based IconButton .

(cherry picked from commit 25b8cb9)
@zahmis
Copy link

zahmis commented Jul 22, 2022

In my case, {...props} cause this problem.
...props include onExited params, so exclude this and use only you need.

Before

  <Dialog {...props}> // <= this!
    <DialogTitle>{title}</DialogTitle>
    <DialogContent>

After

<Dialog open={isOpen}>  <= remove ...props and not warning
</Dialog>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants