Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requests requirement from <2.24,>=2.20 to >=2.20,<2.25 #1687

Closed
wants to merge 1 commit into from
Closed

Update requests requirement from <2.24,>=2.20 to >=2.20,<2.25 #1687

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 10, 2020

Updates the requirements on requests to permit the latest version.

Changelog

Sourced from requests's changelog.

2.24.0 (2020-06-17)

Improvements

  • pyOpenSSL TLS implementation is now only used if Python either doesn't have an ssl module or doesn't support SNI. Previously pyOpenSSL was unconditionally used if available. This applies even if pyOpenSSL is installed via the requests[security] extra (#5443)

  • Redirect resolution should now only occur when allow_redirects is True. (#5492)

  • No longer perform unnecessary Content-Length calculation for requests that won't use it. (#5496)

2.23.0 (2020-02-19)

Improvements

  • Remove defunct reference to prefetch in Session __attrs__ (#5110)

Bugfixes

  • Requests no longer outputs password in basic auth usage warning. (#5099)

Dependencies

  • Pinning for chardet and idna now uses major version instead of minor. This hopefully reduces the need for releases everytime a dependency is updated.

2.22.0 (2019-05-15)

Dependencies

  • Requests now supports urllib3 v1.25.2. (note: 1.25.0 and 1.25.1 are incompatible)

Deprecations

  • Requests has officially stopped support for Python 3.4.

2.21.0 (2018-12-10)

Dependencies

Commits
  • 0797c61 v2.24.0
  • daa2b29 updating usage information
  • 7c71982 Merge pull request #5496 from dbaxa/optimise-prepare-body
  • 71a05cf Avoid an unnecessary computation of the length of data for non-stream request...
  • 737dd0c Update number of dependents on requests (#5495)
  • 8ac5929 Fix typo in README (#5468)
  • 2b3436e Merge pull request #5492 from dbaxa/avoid-calling-resolve_redirects-whe-not-f...
  • fa2dbe9 Remove what appears to be an un-needed call to self.resolve_redirects when no...
  • 9ed5db8 fix raise_for_status docstring (#5293)
  • 427e8eb Fix test_conflicting_post_params to work on pytest 5 (#5305)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update requests requirement from <2.24,>=2.20 to >=2.20,<2.25
c32b595 
Updates the requirements on [requests](https://github.com/psf/requests) to permit the latest version.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/master/HISTORY.md)
- [Commits](psf/requests@v2.20.0...v2.24.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies PR or issue that updates a dependency label Jul 10, 2020
@jcampbell
Copy link
Member

@Shinnnyshinshin -> will you check whether the upstream snowflake issue is resolved?

@Shinnnyshinshin
Copy link
Contributor

Shinnnyshinshin commented Jul 10, 2020 •
edited

@jcampbell as of today, no. the issue is not resolved

On the Snowflake side, the issue is still open, and their recommended fix is to pin the requests package, as we have.

On the requests side, there was a lively discussion regarding only using PyOpenSSL's TLS implementation only if better options like SNI are not available. This is the direction requests seems to be moving, so I don't see them pulling back on this decision.

If we want to keep things working until snowflake-connector-python is updated, do I just close this PR?

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 10, 2020

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/requests-gte-2.20-and-lt-2.25 branch July 10, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinnnyshinshin Shinnnyshinshin Awaiting requested review from Shinnnyshinshin

Assignees
No one assigned
Labels
dependencies PR or issue that updates a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcampbell @Shinnnyshinshin