Remove an obsolete attribute from Session.__attrs__ #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedbat
changed the title
nateprewitt
previously approved these changes
Feb 18, 2020
|
Great catch, @nedbat! That's only been lingering for 8 years . Would you mind rebasing if you get a moment? |
The extra attribute in __attrs__ makes an unpickled session have one more attribute than the original. Removing it makes the original and the unpickled be identical.
|
Rebased, thanks! |
|
Hmm, rebasing and force-pushing apparently also "dismisses stale review"? That certainly wasn't my intent....! |
nateprewitt
approved these changes
Feb 18, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra attribute in
Session.__attrs__makes an unpickled session have one more attribute than the original. Removing it makes the original and the unpickled be identical.