fix(jsutils): use optional chaining to prevent crash in browser #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JoviDeCroock
reviewed
Feb 8, 2024
| @@ -9,7 +9,7 @@ import { inspect } from './inspect.js'; | |||
| export const instanceOf: (value: unknown, constructor: Constructor) => boolean = | |||
| /* c8 ignore next 6 */ | |||
| // FIXME: https://github.com/graphql/graphql-js/issues/2317 | |||
| globalThis.process != null && globalThis.process.env.NODE_ENV === 'production' | |||
| globalThis?.process?.env?.NODE_ENV === 'production' | |||
There was a problem hiding this comment.
Doing it this way will still allow bundlers to remove this condition when process.env.NODE_ENV gets removed by i.e. the replace-plugin
Suggested change
| globalThis?.process?.env?.NODE_ENV === 'production' | |
| globalThis.process != null && globalThis.process.env != null && globalThis.process.env.NODE_ENV === 'production' |
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We use contentful/live-preview. The library has
graphql-jsas a dependency.Problem
If the DOM has an element with
id="process"eg.<div id="process"></div>than the current implementation ofutils/instanceOfwould fail.Current implementation:
with this implementation
globalThis.processwill return the DOM element:Because
globalThis.process is true, the conditionglobalThis.process.env.NODE_ENV === 'production'gets executed and will result with an javascript error: