fix: remove globalThis check and align with what bundlers can accept
#4022
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
JoviDeCroock
force-pushed
the
fix-node-env-issue
branch
2 times, most recently
from
daffdff
to
a8f5b4a
Compare
|
After talking to @phryneas there seems to be a lot of pushback from his side with regards to this change opting out of tree-shaking. I'll probably need more evidence that this breaks on different bundlers |
JoviDeCroock
force-pushed
the
fix-node-env-issue
branch
from
a8f5b4a
to
b0ca7e0
Compare
|
CC @graphql/graphql-js-reviewers |
JoviDeCroock
commented
May 1, 2024
src/jsutils/instanceOf.ts
Outdated
Comment on lines
3
to
11
| /* c8 ignore next 4 */ | ||
| const isProduction = | ||
| // eslint-disable-next-line no-undef | ||
| typeof process !== 'undefined' && | ||
| // eslint-disable-next-line no-undef | ||
| process.env && | ||
| // eslint-disable-next-line no-undef | ||
| process.env.NODE_ENV === 'production'; | ||
|
|
There was a problem hiding this comment.
Another alternative that makes the branch default to production
Suggested change
| /* c8 ignore next 4 */ | |
| const isProduction = | |
| // eslint-disable-next-line no-undef | |
| typeof process !== 'undefined' && | |
| // eslint-disable-next-line no-undef | |
| process.env && | |
| // eslint-disable-next-line no-undef | |
| process.env.NODE_ENV === 'production'; | |
| /* c8 ignore next 4 */ | |
| const isDev = | |
| // eslint-disable-next-line no-undef | |
| typeof process !== 'undefined' && | |
| // eslint-disable-next-line no-undef | |
| process.env.NODE_ENV === 'development'; | |
JoviDeCroock
commented
May 1, 2024
| @@ -9,7 +18,7 @@ import { inspect } from './inspect'; | |||
| export const instanceOf: (value: unknown, constructor: Constructor) => boolean = | |||
| /* c8 ignore next 6 */ | |||
| // FIXME: https://github.com/graphql/graphql-js/issues/2317 | |||
| globalThis.process && globalThis.process.env.NODE_ENV === 'production' | |||
| isProduction | |||
There was a problem hiding this comment.
Suggested change
| isProduction | |
| !isDevelopment |
n1ru4l
approved these changes
May 2, 2024
JoviDeCroock
commented
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As surfaced in Discord this currently is a breaking change in the 16.x.x release line which is preventing folks from upgrading towards a security fix. This PR should result in a patch release on the 16 release line.
This change was originally introduced to support CFW and browser environments which should still be supported with the
typeofcheck CC @n1ru4lThis also adds a check whether
.envis present as in the DOM usingid="process"defines that as a global which we don't want to access on accident. as shown in #4017Bundles also target
process.env.NODE_ENVspecifically which fails when it replacesglobalThis.process.env.NODE_ENVas this becomesglobalThis."production"which is invalid syntax.Fixes #3978
Fixes #3918
Fixes #3758
This purposefully does not account for #3925 as we can't address this without breaking CF/plain browsers so the small byte-size increase will be expected for bundled browser environments. As a middle ground we did optimise the performance here. We can revisit this for v17
Supersedes #4021
Supersedes #4019
Supersedes #3927