Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental: utilize id and subPath rather than path and label #3960

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Aug 25, 2023

to match new format at graphql/defer-stream-wg#69

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 50cf1e6
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64ecd4a23d79680007b7e03e
😎 Deploy Preview https://deploy-preview-3960--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title incremental: add id incremental: utilize id and subPath rather than id and path Aug 28, 2023
@yaacovCR yaacovCR added the PR: breaking change 💥 implementation requires increase of "major" version number label Aug 28, 2023
yaacovCR added a commit that referenced this pull request Aug 28, 2023
@yaacovCR yaacovCR changed the title incremental: utilize id and subPath rather than id and path incremental: utilize id and subPath rather than path and label Aug 28, 2023
@yaacovCR yaacovCR merged commit d2e280a into graphql:main Aug 28, 2023
21 checks passed
@yaacovCR yaacovCR deleted the add-id branch August 28, 2023 17:12
sakesun pushed a commit to sakesun/graphql-js that referenced this pull request Sep 1, 2023
sakesun pushed a commit to sakesun/graphql-js that referenced this pull request Sep 1, 2023
graphql#3960)

updates response format to fully match new format further discussed at
graphql/defer-stream-wg#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants