Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): path is required within incremental results #3961

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Aug 28, 2023

extracted from #3960

thanks @benjie for pointing this out

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 12bfa14
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64ecaeae74e77d00082f845f
😎 Deploy Preview https://deploy-preview-3961--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title path is not optional fix(types): path is required within incremental results Aug 28, 2023
@yaacovCR yaacovCR merged commit d1d66a3 into graphql:main Aug 28, 2023
22 checks passed
@yaacovCR yaacovCR deleted the fix-types branch August 28, 2023 14:37
@yaacovCR yaacovCR added the PR: bug fix 🐞 requires increase of "patch" version number label Aug 28, 2023
sakesun pushed a commit to sakesun/graphql-js that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants