-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer support on ENFs #3395
Merged
andimarek
merged 34 commits into
graphql-java:master
from
felipe-gdr:defer-support-in-enf
Jan 10, 2024
Merged
Defer support on ENFs #3395
Changes from 17 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
9856678
WIP: Implement support for defer in ExecutableNormalizedOperationFactory
felipe-gdr-atlassian 37b1c4a
WIP: ENF to AST Compiler basic implementation
felipe-gdr-atlassian 8b68720
Fix edge case with non-conditional fields in fragments
felipe-gdr-atlassian c85cbed
Fix comment and test
felipe-gdr-atlassian df767cb
Remove commented out code
felipe-gdr 7c047e2
Fix assert error message
felipe-gdr 80dc093
Add tests for 'if' argument
felipe-gdr 407efba
Add dedicated entry point for defer support
felipe-gdr 17f1fab
Add dedicated entrypoint with defer support in the ENFOperationFactory
felipe-gdr 86f9dbe
Add Javadocs
felipe-gdr 0f4abf4
Lots of small adjustments
felipe-gdr 444f775
Add test case for multiple defers at the same level
felipe-gdr 32881a3
Moving over to new implementation: changed method signatures
felipe-gdr 8fe9e38
Conclude refactoring that moves defer support out of ENFs and into ENOs
felipe-gdr da2761e
Clean up defer execution code
felipe-gdr 3f6e480
Add missing Javadoc
felipe-gdr 7f0a37c
Add Javadocs and one more test
felipe-gdr-atlassian e979b77
Apply code formatting
felipe-gdr-atlassian 202573f
Fix edge case
felipe-gdr-atlassian 4db220e
Replace Guava's Multimap with Map in public APIs
felipe-gdr-atlassian 6446ad4
Big refactoring:
felipe-gdr-atlassian b9b0f54
WIP: attempt of getting rid of the NormalizedDeferExecutionFactory
felipe-gdr-atlassian ca1f6d4
Revert "WIP: attempt of getting rid of the NormalizedDeferExecutionFa…
felipe-gdr-atlassian 6ba3e09
Remove excessive normalization that was resulting in reduced number o…
felipe-gdr-atlassian b71a9a4
Big refactor: capture defer executions directly in ENFs
felipe-gdr-atlassian 6a0f9f7
Merge branch 'master' into defer-support-in-enf
felipe-gdr-atlassian eda84d3
post merge adjustments
felipe-gdr-atlassian 87a5b52
Remove irrelevant parameter
felipe-gdr-atlassian 5943b7c
Minor refactors
felipe-gdr-atlassian b04eadc
Rename predicate function
felipe-gdr-atlassian f500132
Rename test and add better documentation
felipe-gdr-atlassian f3e5c84
Small changes after Andi's review
felipe-gdr-atlassian a91fa64
Add Javadoc for DeferExecution
felipe-gdr-atlassian b22fe7a
minor changes
andimarek File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a Map