Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer support on ENFs #3395

Merged
merged 34 commits into from
Jan 10, 2024
Merged

Defer support on ENFs #3395

merged 34 commits into from
Jan 10, 2024

Commits on Dec 5, 2023

  1. WIP: Implement support for defer in ExecutableNormalizedOperationFactory

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    9856678 View commit details
    Browse the repository at this point in the history

  2. WIP: ENF to AST Compiler basic implementation

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    37b1c4a View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Fix edge case with non-conditional fields in fragments

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    8b68720 View commit details
    Browse the repository at this point in the history

  2. Fix comment and test

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c85cbed View commit details
    Browse the repository at this point in the history

  3. Remove commented out code

    @felipe-gdr
    felipe-gdr committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    df767cb View commit details
    Browse the repository at this point in the history

  4. Fix assert error message

    @felipe-gdr
    felipe-gdr committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7c047e2 View commit details
    Browse the repository at this point in the history

  5. Add tests for 'if' argument

    @felipe-gdr
    felipe-gdr committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    80dc093 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Add dedicated entry point for defer support

    @felipe-gdr
    felipe-gdr committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    407efba View commit details
    Browse the repository at this point in the history

  2. Add dedicated entrypoint with defer support in the ENFOperationFactory

    @felipe-gdr
    felipe-gdr committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    17f1fab View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Add Javadocs

    @felipe-gdr
    felipe-gdr committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    86f9dbe View commit details
    Browse the repository at this point in the history

  2. Lots of small adjustments

    @felipe-gdr
    felipe-gdr committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    0f4abf4 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Add test case for multiple defers at the same level

    @felipe-gdr
    felipe-gdr committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    444f775 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Moving over to new implementation: changed method signatures

    @felipe-gdr
    felipe-gdr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    32881a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Conclude refactoring that moves defer support out of ENFs and into ENOs

    @felipe-gdr
    felipe-gdr committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    8fe9e38 View commit details
    Browse the repository at this point in the history

  2. Clean up defer execution code

    @felipe-gdr
    felipe-gdr committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    da2761e View commit details
    Browse the repository at this point in the history

  3. Add missing Javadoc

    @felipe-gdr
    felipe-gdr committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3f6e480 View commit details
    Browse the repository at this point in the history

  4. Add Javadocs and one more test

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7f0a37c View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Apply code formatting

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    e979b77 View commit details
    Browse the repository at this point in the history

  2. Fix edge case

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    202573f View commit details
    Browse the repository at this point in the history

  3. Replace Guava's Multimap with Map in public APIs

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    4db220e View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Big refactoring: 

    - introduce NormalizedDeferExecution
- add defer execution state to ENF
    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    6446ad4 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. WIP: attempt of getting rid of the NormalizedDeferExecutionFactory 

    WIP

WIP
    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b9b0f54 View commit details
    Browse the repository at this point in the history

  2. Revert "WIP: attempt of getting rid of the NormalizedDeferExecutionFa… 

    …ctory"

This reverts commit b9b0f54.
    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    ca1f6d4 View commit details
    Browse the repository at this point in the history

  3. Remove excessive normalization that was resulting in reduced number o… 

    …f defer blocks
    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    6ba3e09 View commit details
    Browse the repository at this point in the history

  4. Big refactor: capture defer executions directly in ENFs

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b71a9a4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into defer-support-in-enf

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    6a0f9f7 View commit details
    Browse the repository at this point in the history

  6. post merge adjustments

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    eda84d3 View commit details
    Browse the repository at this point in the history

  7. Remove irrelevant parameter

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    87a5b52 View commit details
    Browse the repository at this point in the history

  8. Minor refactors

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5943b7c View commit details
    Browse the repository at this point in the history

  9. Rename predicate function

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b04eadc View commit details
    Browse the repository at this point in the history

  10. Rename test and add better documentation

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f500132 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Small changes after Andi's review

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f3e5c84 View commit details
    Browse the repository at this point in the history

  2. Add Javadoc for DeferExecution

    @felipe-gdr-atlassian
    felipe-gdr-atlassian committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a91fa64 View commit details
    Browse the repository at this point in the history

  3. minor changes

    @andimarek
    andimarek committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b22fe7a View commit details
    Browse the repository at this point in the history