New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused scalars from SDL #1423
Conversation
…ypes (in particular scalars)
53127b9
to
1406698
Compare
return builtin scalars to introspection
…o unused-scalars # Conflicts: # src/GraphQL.ApiTests/ApiApprovalTests.PublicApi.GraphQL.approved.txt # src/GraphQL/Introspection/SchemaMetaFieldType.cs
PR is ready for review. Summary changes after information from graphql/graphql-spec#597 :
These changes are in accordance with the specification. @joemcbride, can you do a review, please? |
This PR is no longer needed after rework of
|
…o unused-scalars # Conflicts: # src/GraphQL.ApiTests/ApiApprovalTests.PublicApi.GraphQL.approved.txt # src/GraphQL.StarWars/IoC/SimpleContainer.cs # src/GraphQL.Tests/Introspection/IntrospectionResult.cs # src/GraphQL.Tests/StarWars/StarWarsIntrospectionTests.cs # src/GraphQL.Tests/Utilities/SchemaPrinterTests.cs
…to unused-scalars # Conflicts: # src/GraphQL.ApiTests/GraphQL.approved.txt # src/GraphQL.Tests/Utilities/SchemaPrinterTests.cs # src/GraphQL/GraphQLExtensions.cs # src/GraphQL/Introspection/SchemaMetaFieldType.cs # src/GraphQL/Utilities/SchemaPrinter.cs
OK. As I expected, all scalars are already printed correctly thanks to our edits in other PRs. |
…to unused-scalars
@Shane32 PR is ready for review. |
Codecov Report
@@ Coverage Diff @@
## develop #1423 +/- ##
===========================================
- Coverage 84.07% 84.06% -0.02%
===========================================
Files 371 371
Lines 13098 13076 -22
Branches 1937 1935 -2
===========================================
- Hits 11012 10992 -20
+ Misses 1555 1553 -2
Partials 531 531
Continue to review full report at Codecov.
|
…to unused-scalars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have one minor comment. Please read and then merge at your discretion @sungam3r
According to the specification, it is not necessary to print unused types (in particular scalars).
Relates to graphql/graphql-spec#648