-
-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.0 release #2171
Comments
I will review #2165 tonight. I honestly doubt the need for #2016 but until conflicts are resolved there, I will not look into it.
I have no preference. I hope that I will be able to work for #1451 but only for v4 of course. |
Ok. I'll release 3.3.0 then. I doubt very much if we have any further changes. And if so, they can probably go into 3.3.1. |
@sungam3r What do you think our timing is for releasing 4.0? I know we are working on a few tasks right now:
Do you still want to work these for 4.0?
There are a number of issues in the 4.0 milestone. Is there any of those or anything else you want to work on? I will be happy to do a proper migration document once we are feature-complete (not just some quick bullet points like we have now). It will take a little time but I think @joemcbride would want it completed before we release 4.0. Of course I will need your help for the stuff that relates to #1451. |
#1451 is my primary goal. I promise to watch #1571 again before v4 release. #2191 is no longer relevant, because it turned out that there is already a fluent api for setting the arguments, I just forgot about it. I will not close the PR because I wanted to add something, but it can be postponed. I'll look into #2166 one more time before v4 to make sure we used all relevant optimizations from there.
#1423 if I have time. |
P.S. I need to work on #1571 and update per your comments. I'll tag you when I'm ready. |
@sungam3r What are our remaining goals?
I believe all those tasks are in your court now. Let me know if there's anything else. Will you have enough time to finish this weekend? I won't have hardly any more time to spend on v4 release. |
My weekend ends in 1 hour. I do what I can. |
I think we will finish and merge #2261 tonight. |
Remaining:
|
Fix for #2260 is ready. |
Only few issues left in 4 milestone https://github.com/graphql-dotnet/graphql-dotnet/milestone/7 |
@Shane32 Let's work on #2307 as part of v4. Also, let's take a look at the existing Issues and select the ones that can be quickly fixed. If this requires backward incompatible changes, then it's easier to make them now than wait for the next major version. Also ping @joemcbride for help with federation-related issues. |
Now remaining:
|
I suggest that you look through all the current issues and select those that you are interested in fixing before v4 (provided that it does not take long). |
I would really like to reorganize
Since we have made so many changes to the execution strategy and API layout already, we should review this now, rather than in v5. |
I'm looking through the remaining issues. I don't have anything else on my mind that I would like to complete, except perhaps enhancing the complexity analyzer, but that is probably too much work at this point. |
OK. I go through the issues list starting with the oldest. If I see that the fix does not require much effort, then I do it. And of course I just close issues that are no longer relevant 😄. |
I went through the entire issues list just now. All of the issues in the 4.0 milestone have PRs ready for you to review, I believe, besides #344 . I think we should finish cleanup on the execution strategy and scalars and be done. |
OK. The review will take a couple of days. |
Current status:
What about #2257 ? The single confirmed bug left. I'm not sure. |
@sungam3r As far as I'm concerned, we can release 4.0 as soon as you can help finish PR #2357 - specifically where the Custom Scalars documentation page describes how to replace a built-in scalar. We should certainly write a test to demonstrate the proposed solution, as it is very possible that people want to (for example) continue to allow integer values for a boolean scalar (which is allowed but not mandatory per spec). I will propose changes to |
Today I will work on it. |
Regarding #2357 see #2357 (comment) |
+ #2370 ? |
#2370 should be a high priority for sure. I don't know if it needs to hold up v4 release, but go ahead and tag it 4.0. |
Current status of issues holding up v4:
Non-breaking changes that can be done AFTER 4.0:
I do not plan on making any more breaking changes. |
Releasing as is without #2342 or wait one day for @joemcbride ? |
I can review #2379 tonight. |
Wait another day is fine. |
If you want to approve #2397, I can release 4.0, ok? |
I'll review it again after 2-3 hours. |
#2342 was approved 👍 |
#2380 waiting for comments from spec guys. Not a goal for v4. |
#2397 approved |
Let's deal with #2379 first and then release v4. |
And #2403. |
I think you may to write a notes for v4 in a such way:
|
Draft release text@sungam3r I listed the new features in no particular order. Feel free to update this and specifically write a little more about the applied directives feature that was added, in addition to anything else I missed. See below draft: Version 4.0New features:
See migration guide here: See main documentation here: See list of resolved issues and merged PRs for 4.0: |
Only one issue left - #2379. |
EVERYTHING IS DONE! |
|
Patches on 3.x should be applied to |
Seems logical. |
Will v5.0.0 of GraphQL.Server be following soon? |
Yes. |
@sungam3r Similar to previous versions, 4.1 is listed as 30 days out (4/15) and 5.0 is listed as 6 months out (9/1). We can change as desired of course, but just setting a goal is good. |
OK |
https://github.com/graphql-dotnet/graphql-dotnet/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.0
@sungam3r Please keep in mind that if we intend to keep that date, we need to keep moving through changes. We need graphql-dotnet/parser#101 merged so we can make related changes in this repo. (Specifically, I want to review the CoreToVanilla converter, unless you're going to, and review the execution process for "precompilation" #2016 .) I need #2165 reviewed and merged so I can continue with additional changes in a new PR for my input coercion work.
I know we are all pressed for time, but if you can review my PRs as soon as your free time allows, then I can continue working (especially now as I have a lot of free time for the next week or two). I will do the same for your PRs.
Keep in mind that we do not have migration documentation written; just some simple bullet points. Based on the v3 release, I anticipate that @joemcbride does not want us to release a new version without a good migration document. I can do this as soon as we can get through the changes.
Finally, we have been adding to the 4.0 milestone without taking anything off of it. We need to review the milestone goals again.
Don't mistake me - I do think we should release 4.0 "soon", and if we run out of time, let's just set our goals and stop there. We should not have 4.0 perpetually in limbo like 3.0 was.
Let's use this topic to discuss and track the progress for 4.0
Last question: Is there anything else you foresee adding to 3.3.0? I don't know of anything.
The text was updated successfully, but these errors were encountered: