Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with --disable-proto=delete (partly for Deno compatibility) #1902

Merged
merged 2 commits into from Jan 5, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Jan 5, 2024

Description

Fixes #1897. Everything was already fine, but this helps prevent a regression.

Performance impact

None.

Security impact

None.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: 1b6c2f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
tamedevil Patch
grafast Patch
ruru-components Patch
graphile-build-pg Patch
graphile-utils Patch
pgl Patch
postgraphile Patch
@localrepo/grafast-bench Patch
@dataplan/json Patch
@dataplan/pg Patch
@grafserv/persisted Patch
grafserv Patch
@localrepo/grafast-website Patch
graphile-build Patch
graphile-export Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit 2d41885 into main Jan 5, 2024
24 checks passed
@benjie benjie deleted the null-proto branch January 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Outdated chalk dependency breaks Postgraphile when running with --disable-proto=delete or using Deno
1 participant