Run tests with --disable-proto=delete (partly for Deno compatibilit…

…y) (#1902)
graphile · Jan 5, 2024 · 2d41885 · 2d41885
2 parents 12a53b4 + 1b6c2f6
commit 2d41885
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/light-pandas-complain.md b/.changeset/light-pandas-complain.md
@@ -0,0 +1,5 @@
+---
+"tamedevil": patch
+---
+
+Forbid `__proto__` set even when `--disable-proto=delete` option is in use.
diff --git a/.github/workflows/test-base.yml b/.github/workflows/test-base.yml
@@ -37,7 +37,7 @@ jobs:
       TEST_SIMPLIFY_DATABASE_URL: postgres://postgres:postgres@localhost:5432/pg_simplify_inflectors
       TERM: xterm
       FORCE_COLOR: 1
-      NODE_OPTIONS: "--max-old-space-size=4096"
+      NODE_OPTIONS: "--max-old-space-size=4096 --disable-proto=delete"
 
     strategy:
       fail-fast: false

diff --git a/utils/tamedevil/src/index.ts b/utils/tamedevil/src/index.ts
@@ -641,6 +641,11 @@ const disallowedKeys: Array<string | symbol | number> = [
   ...Object.getOwnPropertyNames(Object.prototype),
   ...Object.getOwnPropertySymbols(Object.prototype),
 ];
+if (!disallowedKeys.includes("__proto__")) {
+  // If you're running with `--disable-proto=delete` we still want to check
+  // you're not trying to set __proto__.
+  disallowedKeys.push("__proto__");
+}
 
 /**
  * Returns true if the given key is safe to set as the key of a POJO (without a