Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo: Fix TraceQL autocomplete issues (#60058) #60125

Merged
merged 4 commits into from Dec 12, 2022

Conversation

CrypticSignal
Copy link
Contributor

@CrypticSignal CrypticSignal commented Dec 9, 2022

This PR improves autocomplete when using the TraceQL query editor. More specifically, situations where the autocomplete values are not sufficiently filtered (#60058).

@CrypticSignal CrypticSignal marked this pull request as ready for review December 12, 2022 13:36
@CrypticSignal CrypticSignal requested a review from a team as a code owner December 12, 2022 13:36
@grafanabot
Copy link
Contributor

Hello @CrypticSignal!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@CrypticSignal CrypticSignal merged commit 583aafb into main Dec 12, 2022
@CrypticSignal CrypticSignal deleted the hamas/traceql-fix-autocomplete-issues branch December 12, 2022 14:49
@grafanabot
Copy link
Contributor

The backport to v9.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-60125-to-v9.3.x origin/v9.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 583aafbbd84ccebfa765bfac65b839fc4d33b995
# Push it to GitHub
git push --set-upstream origin backport-60125-to-v9.3.x
git switch main
# Remove the local backport branch
git branch -D backport-60125-to-v9.3.x

Then, create a pull request where the base branch is v9.3.x and the compare/head branch is backport-60125-to-v9.3.x.

@grafanabot grafanabot added the backport-failed Failed to generate backport PR. Please resolve conflicts and create one manually. label Dec 12, 2022
CrypticSignal pushed a commit that referenced this pull request Dec 12, 2022
@adrapereira adrapereira linked an issue Dec 13, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TraceQL Autocomplete Issues
3 participants