Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceQL Autocomplete Issues #60058

Closed
joe-elliott opened this issue Dec 8, 2022 · 2 comments · Fixed by #60125
Closed

TraceQL Autocomplete Issues #60058

joe-elliott opened this issue Dec 8, 2022 · 2 comments · Fixed by #60125
Assignees
@adrapereira
Labels
area/tracing datasource/Tempo prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/bug

Comments

@joe-elliott
Copy link
Member

What happened:
TraceQL autocomplete suggests invalid options in some cases.

  1. After typing the global attribute scope . it suggests the scopes resource and span as well as intrinsics such as duration, but only custom attributes should be suggested after a .

image

  1. After typing a specific scope such as span. or resource. it suggests instrinsics such as duration but it should only suggest custom attributes

image

What you expected to happen:

Not to suggest those things.

How to reproduce it (as minimally and precisely as possible):

Type the things above.
@evandandrea
Copy link

We'd like this to land in time for the Tempo 2.0 release

@aocenas aocenas added the prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 9, 2022
@CrypticSignal CrypticSignal mentioned this issue Dec 9, 2022
Merged
CrypticSignal pushed a commit that referenced this issue Dec 12, 2022
Tempo: Fix TraceQL autocomplete issues (#60058) (#60125)
583aafb
CrypticSignal pushed a commit that referenced this issue Dec 12, 2022
Tempo: Fix TraceQL autocomplete issues (#60058) (#60125)
846feb5 
(cherry picked from commit 583aafb)
CrypticSignal pushed a commit that referenced this issue Dec 13, 2022
[v9.3.x] Tempo: Fix TraceQL autocomplete issues (#60058) (#60125) (#6…
c11e547 
…0170)
@adrapereira adrapereira linked a pull request Dec 13, 2022 that will close this issue
Tempo: Fix TraceQL autocomplete issues (#60058) #60125
Merged
@adrapereira
Copy link
Contributor

Fixed in #60125

GuYounes pushed a commit to paul-wurth/BIXpert that referenced this issue Feb 8, 2023
@GuaYounesPW
[v9.3.x] Tempo: Fix TraceQL autocomplete issues (grafana#60058) (graf…
4b01f8f 
…ana#60125) (grafana#60170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrapereira adrapereira

Labels
area/tracing datasource/Tempo prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tempo: Fix TraceQL autocomplete issues (#60058) grafana/grafana
4 participants
@aocenas @evandandrea @joe-elliott @adrapereira