Dashboards: Show error when data source is missing #60099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
requested review from
a team,
ashharrison90,
JoaoSilvaGrafana,
academo,
codeincarnate and
oscarkilhed
and removed request for
a team
This comment was marked as resolved.
This comment was marked as resolved.
joshhunt
changed the title
polibb
approved these changes
Dec 13, 2022
grafanabot
pushed a commit
that referenced
this pull request
Dec 14, 2022
Return caught exceptions to panel as error state (cherry picked from commit 9a41277)
joshhunt
added a commit
that referenced
this pull request
Dec 14, 2022
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…60313) Dashboards: Show error when data source is missing (grafana#60099) Return caught exceptions to panel as error state (cherry picked from commit 9a41277) Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Shows an error on panels when the data source is missing.
The error was already being caught, but it was just ignored. This just pipes it through to the observable so it can be shown to the user.
Fixes #60088
You can test this by importing the dashboard from #60088