Dashboards: Show error when data source is missing (#60099)

Return caught exceptions to panel as error state (cherry picked from commit 9a41277)
grafana · Dec 14, 2022 · e3ce69e · e3ce69e
1 parent 21c1d14
commit e3ce69e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/grafana-runtime/src/utils/toDataQueryError.ts b/packages/grafana-runtime/src/utils/toDataQueryError.ts
@@ -6,7 +6,7 @@ import { DataQueryError } from '@grafana/data';
  *
  * @public
  */
-export function toDataQueryError(err: DataQueryError | string | Object): DataQueryError {
+export function toDataQueryError(err: DataQueryError | string | unknown): DataQueryError {
   const error = (err || {}) as DataQueryError;
 
   if (!error.message) {

diff --git a/public/app/features/query/state/PanelQueryRunner.ts b/public/app/features/query/state/PanelQueryRunner.ts
@@ -25,7 +25,7 @@ import {
   toDataFrame,
   transformDataFrame,
 } from '@grafana/data';
-import { getTemplateSrv } from '@grafana/runtime';
+import { getTemplateSrv, toDataQueryError } from '@grafana/runtime';
 import { ExpressionDatasourceRef } from '@grafana/runtime/src/utils/DataSourceWithBackend';
 import { StreamingDataFrame } from 'app/features/live/data/StreamingDataFrame';
 import { isStreamingDataFrame } from 'app/features/live/data/utils';
@@ -274,7 +274,15 @@ export class PanelQueryRunner {
 
       this.pipeToSubject(runRequest(ds, request), panelId);
     } catch (err) {
-      console.error('PanelQueryRunner Error', err);
+      this.pipeToSubject(
+        of({
+          state: LoadingState.Error,
+          error: toDataQueryError(err),
+          series: [],
+          timeRange: request.range,
+        }),
+        panelId
+      );
     }
   }