Prometheus: Fix exemplars not respecting corresponding series display status. #59743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk-grafana
commented
Dec 5, 2022
public/app/plugins/panel/timeseries/plugins/ExemplarsPlugin.tsx
Outdated
Show resolved
Hide resolved
gtk-grafana
changed the title
|
Getting closer, although the code is getting messier, but there's still a bug when you're viewing multiple series (by holding shift and clicking), in which only a single label filter is being applied. |
…lars wouldn't filter
gtk-grafana
requested review from
a team,
codeincarnate and
oscarkilhed
and removed request for
a team
|
The e2e test cases we currently have are only testing a single series, we'll need to revisit our exemplar e2e tests in another issue: #59911. |
…any label name, label value combination
|
@itsmylife thanks for the feedback, I've implemented a unit test for the exported function. Can you take another look in the morning? |
…678/exemplars-not-filtering-from-legend
bohandley
approved these changes
Dec 8, 2022
itsmylife
approved these changes
Dec 8, 2022
gtk-grafana
changed the title
…678/exemplars-not-filtering-from-legend
gtk-grafana
deleted the
gtk-grafana/issues/59678/exemplars-not-filtering-from-legend
branch
gtk-grafana
added a commit
that referenced
this pull request
Dec 8, 2022
… time series. (#60054) Prometheus: Fix exemplar fill color to match series color in time series. (#59908) * Implementing new optional color property to ExemplarMarker component * Refactor some changes from #59743 (cherry picked from commit dfc1516) Co-authored-by: Galen Kistler <109082771+gtk-grafana@users.noreply.github.com>
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…s display status. (grafana#60047) Prometheus: Fix exemplars not respecting corresponding series display status. (grafana#59743) * Exemplar filtering when series are toggled in legend UI (cherry picked from commit 22f8283) Co-authored-by: Galen Kistler <109082771+gtk-grafana@users.noreply.github.com>
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
… time series. (grafana#60054) Prometheus: Fix exemplar fill color to match series color in time series. (grafana#59908) * Implementing new optional color property to ExemplarMarker component * Refactor some changes from grafana#59743 (cherry picked from commit dfc1516) Co-authored-by: Galen Kistler <109082771+gtk-grafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Fix bug in which exemplars do not filter when a series is hidden via user clicking on the legend UI.
Currently, when filtering a metric with multiple labels/series via the legend UI, the exemplars do not respect the active filters, and will always display all exemplars in the current time-series graph.
Why do we need this feature?
Users with many labels for a single series in an exemplar query are left with a heap of exemplars that are not differentiated. This PR allows users to hide series from the graph and only view the relevant exemplars.
Who is this feature for?
Users of prometheus exemplars.
Which issue(s) does this PR fix?:
Fixes #59678
Special notes for your reviewer:
This might not be the most clean or efficient solution, please let me know if there's any improvements we can make to this!
Debug snapshot from the TNS app:
histogram_quantile(0.95, sum by(le, job) (rate(tns_request_duration_seconds_bucket[$__rate_interval])))debug-Exemplar 1 metric 3 labels-2022-12-07 11_53_14.json.txt