Prometheus: Fix exemplar fill color to match series color in time series. #59908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lars wouldn't filter
gtk-grafana
requested review from
a team,
zoltanbedi and
mdvictor
and removed request for
a team
gtk-grafana
commented
Dec 6, 2022
gtk-grafana
commented
Dec 6, 2022
public/app/plugins/panel/timeseries/plugins/ExemplarsPlugin.tsx
Outdated
Show resolved
Hide resolved
|
|
…678/exemplars-not-filtering-from-legend
…egend' into gtk-grafana/issues/59499/exemplar-colors
…678/exemplars-not-filtering-from-legend
|
Hello @gtk-grafana!
Please, if the current pull request addresses a bug fix, label it with the |
gtk-grafana
added
the
product-approved
…678/exemplars-not-filtering-from-legend
gtk-grafana
changed the title
Base automatically changed from
gtk-grafana/issues/59678/exemplars-not-filtering-from-legend
to
main
December 8, 2022 17:46
…499/exemplar-colors
gtk-grafana
added a commit
that referenced
this pull request
Dec 8, 2022
… time series. (#60054) Prometheus: Fix exemplar fill color to match series color in time series. (#59908) * Implementing new optional color property to ExemplarMarker component * Refactor some changes from #59743 (cherry picked from commit dfc1516) Co-authored-by: Galen Kistler <109082771+gtk-grafana@users.noreply.github.com>
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
… time series. (grafana#60054) Prometheus: Fix exemplar fill color to match series color in time series. (grafana#59908) * Implementing new optional color property to ExemplarMarker component * Refactor some changes from grafana#59743 (cherry picked from commit dfc1516) Co-authored-by: Galen Kistler <109082771+gtk-grafana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Matching exemplar color to the color of the series.
Why do we need this feature?
Current exemplar UX is difficult to differentiate exemplars from different labels within a single metric.
Who is this feature for?
Customers with exemplars that want to build more complicated graphs.
Which issue(s) does this PR fix?:
Fixes #59499
Debug log:
histogram_quantile(0.90, sum by(le, job, status_code) (rate(tns_request_duration_seconds_bucket[$__rate_interval])))debug-Exemplar 1 metric 10 labels-2022-12-07 16_00_31.json.txt
Special notes for your reviewer: