Graphite: Process multiple queries to Graphite plugin #59608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-graphite-queries' into mmandrus/fix-multiple-graphite-queries
This reverts commit 26b6463.
itsmylife
approved these changes
Dec 1, 2022
mmandrus
changed the title
|
Hi, thanks for the fix. Unfortunately looks like this may have now broken the wildcard queries. While I can now confirm this fixes the original issue, now any wildcard metrics are only showing the last match of the set. Shall I open new issue with screenshots etc? |
|
Just to note wildcards were working in the original issue and were the only way to get multiple lines. This is now kind of the reverse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Updates the Graphite datasource plugin to handle multiple queries, instead of just the last one in the list. It aliases each query in order to correlate queries with results.
Why do we need this feature?
The current behavior is causing issues in public dashboards, which we had previously not seen because the front end sends graphite queries to Graphite through the proxy instead of through /ds/query.
Which issue(s) does this PR fix?:
Fixes #59601
Special notes for your reviewer:
There is some less-than-ideal code in here to handle associating graphite query results with requests, but based on my research, it would not be safe to rely on result order aligning with query order. Using aliases seemed to be the safest approach.
An alternative would have been to send off multiple different queries to Graphite, but this seemed preferred to minimize the impact of errors.