Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public dashboard only rendering one metric from Graphite wildcard query #60141

Closed
bobemoe opened this issue Dec 12, 2022 · 5 comments · Fixed by #60549
Closed

Public dashboard only rendering one metric from Graphite wildcard query #60141

bobemoe opened this issue Dec 12, 2022 · 5 comments · Fixed by #60549

Comments

@bobemoe
Copy link
Contributor

bobemoe commented Dec 12, 2022

What happened:

Since the refactoring done in #59608 public dashboard graphite wildcard queries now only render the last metric matched.

What you expected to happen:

All matching metrics rendered.

How to reproduce it (as minimally and precisely as possible):

Create new dashboard with Graphite source, and a wildcard query that returns 2 or more metrics: (optionally as seen in screenshot I also added a non-wildcard query, just to test that too, but its not necessary to trigger the issue)

image

Save, share as public. See the wildcard query only rendering one metric on the public dashboard:

image

Anything else we need to know?:

Environment:

  • Grafana version: [v9.4.0-92566pre (7bf7308)]
  • Data source type & version: Graphite
  • OS Grafana is installed on: Docker
  • User OS & Browser: Linux, FF
  • Grafana plugins: Default
  • Others:
@bohandley
Copy link
Contributor

Hi @bobemoe! Thank you for finding this, so this is only in public dashboards as a result of the change to handle multiple queries? @mmandrus any thoughts?

@bobemoe
Copy link
Contributor Author

bobemoe commented Dec 13, 2022

so this is only in public dashboards as a result of the change to handle multiple queries? - @bohandley

Yep, it certainly seems that way. I reported the original issue (at which point wildcards were rendering but multiple queries weren't) and upon testing the fix (multiple queries now work) noticed the wildcard now doesn't work!

@mmandrus
Copy link
Contributor

Hi @bobemoe, thanks for reporting this and apologies for not catching it! The pubdash team will investigate.

@bobemoe
Copy link
Contributor Author

bobemoe commented Dec 13, 2022

No worries, awesome project. Thanks for everything.

@mmandrus
Copy link
Contributor

Look for this fix in the 9.3.3 release in mid-January. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants