feat: change default nfpm bindir #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/usr/local/bin is intended for binaries compiled locally, which is never the case for goreleaser. this changes the default to /usr/bin instead. closes #2909 Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
pull-request-size
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## main #2910 +/- ##
=======================================
Coverage 84.49% 84.49%
=======================================
Files 111 111
Lines 8903 8903
=======================================
Hits 7523 7523
Misses 1109 1109
Partials 271 271
Continue to review full report at Codecov.
|
staticdev
approved these changes
Feb 14, 2022
|
@caarlos0 do you have a plan to have a release with this in the following days? |
|
yes, likely this weekend |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/local/binis intended for binaries compiled locally, which is never the case for goreleaser.This PR changes the default to
/usr/bininstead.closes #2909