Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rollback default bindir for new goreleaser. #5816

Merged
merged 1 commit into from Jan 25, 2023
Merged

fix: rollback default bindir for new goreleaser. #5816

merged 1 commit into from Jan 25, 2023

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Jan 24, 2023 •
edited

Description

goreleaser changed the default bindir, and I did not notice it when updating goreleaser in #5642
goreleaser/goreleaser#2910

Test Plan

Install the debian packages and try running master & agent.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@ioga ioga requested a review from a team as a code owner January 24, 2023 23:06
@ioga ioga requested a review from eecsliu January 24, 2023 23:06
@cla-bot cla-bot bot added the cla-signed label Jan 24, 2023
@netlify
Copy link

netlify bot commented Jan 24, 2023 •
edited

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 56cf7a0
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/63d064853c73cf000866c4e5
😎 Deploy Preview https://deploy-preview-5816--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ioga ioga requested a review from erikwilson January 25, 2023 01:59
@ioga ioga merged commit 3ff86ee into determined-ai:master Jan 25, 2023
@ioga ioga deleted the fix-default-bindir branch January 25, 2023 02:10
@ioga ioga mentioned this pull request Jan 26, 2023
Merged
4 tasks
@dannysauer dannysauer added this to the 0.19.11 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamidzr hamidzr hamidzr approved these changes

@eecsliu eecsliu Awaiting requested review from eecsliu eecsliu was automatically assigned from determined-ai/backend

@erikwilson erikwilson Awaiting requested review from erikwilson

Assignees

@hamidzr hamidzr

Labels
cla-signed
Projects
None yet
Milestone
0.19.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ioga @hamidzr @dannysauer