Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update existing release drafts #3073

Merged
merged 1 commit into from May 9, 2022
Merged

fix: update existing release drafts #3073

merged 1 commit into from May 9, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Apr 28, 2022 •
edited

find existing draft release by list all releases

otherwise it don't update exiting draft release, but create a duplicated one.

Closes: #3072

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #3073 (5670ec7) into main (a77ed9a) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3073      +/-   ##
==========================================
- Coverage   84.56%   84.32%   -0.25%     
==========================================
  Files         112      112              
  Lines        9222     9249      +27     
==========================================
  Hits         7799     7799              
- Misses       1149     1176      +27     
  Partials      274      274
Impacted Files Coverage Δ
internal/client/github.go 34.45% <0.00%> (-3.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77ed9a...5670ec7. Read the comment docs.

@caarlos0 caarlos0 changed the title find existing draft release by list all releases fix: update existing release drafts May 9, 2022
@caarlos0 caarlos0 merged commit e290270 into goreleaser:main May 9, 2022
@caarlos0
Copy link
Member

caarlos0 commented May 9, 2022

thanks!

@github-actions github-actions bot added this to the v1.9.0 milestone May 9, 2022
@yihuang yihuang deleted the fix-draft-release branch May 9, 2022 01:27
@caarlos0 caarlos0 mentioned this pull request May 20, 2022
Closed
3 tasks
caarlos0 added a commit that referenced this pull request May 20, 2022
@caarlos0
fix: draft release when no existing draft release exists
0b33059 
closes #3115
refs #3073

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
caarlos0 added a commit that referenced this pull request May 20, 2022
@caarlos0
Revert "fix: update existing release drafts (#3073)"
cc27fba 
This reverts commit e290270.
@caarlos0 caarlos0 mentioned this pull request Jun 9, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

goreleaser can't update existing draft release
2 participants
@yihuang @caarlos0